Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Natively support Memory<byte> #2311

Open
wants to merge 11 commits into
base: master
Choose a base branch
from

Conversation

verdie-g
Copy link

@verdie-g verdie-g commented Sep 13, 2024

There are many PRs open aiming to extend the API to allow low allocation produce but they all have some caveats:

Instead of adding a third type of serializer (after ISerializer and IAsyncSerializer), this PR makes a special case for Memory<byte> (and ReadOnlyMemory<byte>) to by pass the serializers and directly use Message.Value or Message.Key.

Closes #1238.

Copy link

cla-assistant bot commented Sep 13, 2024

CLA assistant check
All committers have signed the CLA.

Copy link

cla-assistant bot commented Sep 13, 2024

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@verdie-g verdie-g marked this pull request as ready for review September 16, 2024 15:36
@verdie-g verdie-g requested review from a team as code owners September 16, 2024 15:36
@bmesetovic
Copy link

There seems to be no progress on either of the several approaches to reduce allocations on the publishing side of Kafka. All of them are stuck at the review phase.

We are affected by the issue as well and would really like to see how we can push this topic so that it finally gets the attention it deserves.

@verdie-g Did you end up forking the project and adding your changes?

@verdie-g
Copy link
Author

We used a fork with #2219 just to confirm the important performance benefits but we were not ready to maintain a fork.

We are still waiting for a review on that PR.

@confluent-cla-assistant
Copy link

confluent-cla-assistant bot commented Nov 18, 2024

🎉 All Contributor License Agreements have been signed. Ready to merge.
✅ verdie-g
Please push an empty commit if you would like to re-run the checks to verify CLA status for all contributors.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SerializationContext
2 participants