Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added a timestamp unit to partitioner config #122

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

added a timestamp unit to partitioner config #122

wants to merge 1 commit into from

Conversation

bagipriyank
Copy link

@bagipriyank bagipriyank commented Jan 27, 2020 •
edited
Loading

Fixes #121

@ghost
Copy link

ghost commented Jan 27, 2020

It looks like @bagipriyank hasn't signed our Contributor License Agreement, yet.

The purpose of a CLA is to ensure that the guardian of a project's outputs has the necessary ownership or grants of rights over all contributions to allow them to distribute under the chosen licence.
Wikipedia

You can read and sign our full Contributor License Agreement here.

Once you've signed reply with [clabot:check] to prove it.

Appreciation of efforts,

clabot

@bagipriyank
Copy link
Author

[clabot:check]

@ghost
Copy link

ghost commented Jan 27, 2020

It looks like @bagipriyank hasn't signed our Contributor License Agreement, yet.

The purpose of a CLA is to ensure that the guardian of a project's outputs has the necessary ownership or grants of rights over all contributions to allow them to distribute under the chosen licence.
Wikipedia

You can read and sign our full Contributor License Agreement here.

Once you've signed reply with [clabot:check] to prove it.

Appreciation of efforts,

clabot

@bagipriyank
Copy link
Author

[clabot:check]

@ghost
Copy link

ghost commented Jan 27, 2020

@confluentinc It looks like @bagipriyank just signed our Contributor License Agreement. 👍

Always at your service,

clabot

@bagipriyank bagipriyank changed the title added a timestamp unit to partitioner config Fixes #121 added a timestamp unit to partitioner config Jan 28, 2020
@bagipriyank bagipriyank changed the title Fixes #121 added a timestamp unit to partitioner config added a timestamp unit to partitioner config Jan 28, 2020
@bagipriyank
Copy link
Author

@kkonstantine could you please have a look?

@hariprasad-k hariprasad-k mentioned this pull request Mar 5, 2020
Open
@OneCricketeer OneCricketeer mentioned this pull request Mar 11, 2020
Open
@kkonstantine kkonstantine requested review from a team and removed request for kkonstantine August 8, 2024 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

add a property to tell timestamp extractor whether timestamp value is in seconds or milliseconds
1 participant
@bagipriyank