Skip to content

Commit

Permalink
KSQL-12955 | Fix checkstyle errors.
Browse files Browse the repository at this point in the history
  • Loading branch information
pbadani committed Jan 27, 2025
1 parent efb9826 commit fb2753f
Show file tree
Hide file tree
Showing 4 changed files with 13 additions and 15 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,9 @@ public class KsqlResourceContextImpl implements KsqlResourceContext {
private final KsqlConfig ksqlConfig;
private final KsqlRestConfig ksqlRestConfig;

public KsqlResourceContextImpl(KsqlConfig ksqlConfig, KsqlRestConfig restConfig) {
public KsqlResourceContextImpl(
final KsqlConfig ksqlConfig,
final KsqlRestConfig restConfig) {
this.ksqlConfig = ksqlConfig;
this.ksqlRestConfig = restConfig;
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,6 @@
package io.confluent.ksql.rest.extensions;

import io.confluent.ksql.util.KsqlException;

import java.io.Closeable;

public interface KsqlResourceExtension extends Closeable {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -126,7 +126,6 @@
import io.vertx.core.net.SocketAddress;
import io.vertx.ext.dropwizard.DropwizardMetricsOptions;
import io.vertx.ext.dropwizard.Match;

import java.io.Console;
import java.io.File;
import java.io.IOException;
Expand Down Expand Up @@ -321,21 +320,21 @@ public static SourceName getCommandsStreamName() {
public void startAsync() {
log.debug("Starting the ksqlDB API server");

KsqlResourceContext ksqlResourceContext
final KsqlResourceContext ksqlResourceContext
= new KsqlResourceContextImpl(ksqlConfigNoPort, restConfig);

boolean isFipsValidatorConfigured = false;
for (KsqlResourceExtension resourceExtension : ksqlResourceExtensions) {
resourceExtension.register(ksqlResourceContext);
if (KsqlConstants.FIPS_VALIDATOR
.equals(resourceExtension.getClass().getCanonicalName())) {
isFipsValidatorConfigured = true;
isFipsValidatorConfigured = true;
}
}
if (ksqlConfigNoPort.enableFips() && !isFipsValidatorConfigured) {
throw new KsqlException("Error enabling the FIPS resource extension: `enable.fips` is set to true but the "
+ "`ksql.resource.extension.class` config is either not configured or does not contain \""
+ KsqlConstants.FIPS_VALIDATOR + "\"");
throw new KsqlException("Error enabling the FIPS resource extension: `enable.fips` is set"
+ " to true but the `ksql.resource.extension.class` config is either not configured"
+ " or does not contain \"" + KsqlConstants.FIPS_VALIDATOR + "\"");
}

this.serverMetadataResource = ServerMetadataResource.create(serviceContext, ksqlConfigNoPort);
Expand Down Expand Up @@ -535,11 +534,11 @@ public void shutdown() {
});

ksqlResourceExtensions.forEach(resourceExtension -> {
try {
resourceExtension.close();
} catch (IOException e) {
log.error("Exception while closing resource extension", e);
}
try {
resourceExtension.close();
} catch (IOException e) {
log.error("Exception while closing resource extension", e);
}
});

try {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -24,8 +24,6 @@
import io.confluent.ksql.logging.query.QueryLogger;
import io.confluent.ksql.metrics.MetricCollectors;
import io.confluent.ksql.properties.PropertiesUtil;
import io.confluent.ksql.rest.extensions.KsqlResourceContext;
import io.confluent.ksql.rest.extensions.KsqlResourceContextImpl;
import io.confluent.ksql.rest.server.state.ServerState;
import io.confluent.ksql.serde.FormatFactory;
import io.confluent.ksql.util.KsqlConfig;
Expand Down

0 comments on commit fb2753f

Please sign in to comment.