Improve docs #356
Merged
Improve docs #356
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Soph1514 Would you like to help with this PR? It could be a great collaboration practice before we start working on rule engine! |
YehorBoiar
commented
Oct 5, 2024
| @@ -143,7 +261,7 @@ fn apply_all_rules<'a>( | |||
| ) -> Vec<RuleResult<'a>> { | |||
| let mut results = Vec::new(); | |||
| for rule in rules { | |||
| match rule.apply(expression, model) { | |||
There was a problem hiding this comment.
Accidentally changed this line
|
Commented out the docstring examples as they were causing the cargo test --workspace command to fail in the CI pipeline. The examples were meant to provide additional context for abstract functions but aren't critical to the descriptions. Open to feedback on whether to rework these examples to pass the tests or move them to a separate file for better context without affecting the CI process. @ozgurakgun |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improving documentation. Ideally, I would like to see all methods and methods` parametres in rule_engine documented.
TODO for rewrite.rs: