Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move _tcplistener.Start() from Run() function to Start() function #928

Merged
merged 2 commits into from
Jan 24, 2025
Merged

Move _tcplistener.Start() from Run() function to Start() function #928

merged 2 commits into from
Jan 24, 2025

Conversation

hlibman-connamara
Copy link
Collaborator

resolves #392

gbirchmeier
gbirchmeier approved these changes Jan 24, 2025
View reviewed changes
Copy link
Member

@gbirchmeier gbirchmeier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I undid your merge commits and rebased your tree properly, so your 2 commits are now the most recent. (and I tweaked the wording of the release notes)

Please don't use git merge on your dev branches. Use git rebase.

@gbirchmeier gbirchmeier merged commit c2b2d7d into connamara:master Jan 24, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gbirchmeier gbirchmeier gbirchmeier approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Exception in socket acceptor thread crashing the whole application
2 participants
@hlibman-connamara @gbirchmeier