Merge pull request #512 from connection-2023/feature/#501

Feat(#501): lecture not found exception
connection-2023 · May 13, 2024 · a9c09a2 · a9c09a2
2 parents 7490bcd + 49d6b4b
commit a9c09a2
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 1 deletion.
diff --git a/src/chats/services/chats-room.service.ts b/src/chats/services/chats-room.service.ts
@@ -61,7 +61,7 @@ export class ChatRoomService {
 
     await Promise.all(
       onlineMap.map((online) => {
-        if (!online.lastLogin) {
+        if (online && !online.lastLogin) {
           this.eventsGateway.server
             .to(online.socketId)
             .emit('handleNewChatRoom', chatRoom.roomId);

diff --git a/src/chats/services/chats.service.ts b/src/chats/services/chats.service.ts
@@ -44,6 +44,10 @@ export class ChatsService {
       roomObjectId,
     );
 
+    if (!chatRoom) {
+      throw new NotFoundException('ChatRoom was not found', 'NotFoundChatRoom');
+    }
+
     const userParticipation = chatRoom.user.participation;
     const lecturerParticipation = chatRoom.lecturer.participation;
 

diff --git a/src/lecture/services/lecture.service.ts b/src/lecture/services/lecture.service.ts
@@ -248,12 +248,20 @@ export class LectureService {
       ? await this.lectureRepository.readLecture(lectureId, userId)
       : await this.lectureRepository.readLecture(lectureId);
 
+    if (!lecture) {
+      throw new NotFoundException('Lecture was not found', 'NotFoundLecture');
+    }
+
     return new LecturePreviewDto(lecture);
   }
 
   async readLectureDetail(lectureId: number) {
     const lecture = await this.lectureRepository.readLecture(lectureId);
 
+    if (!lecture) {
+      throw new NotFoundException('Lecture was not found', 'NotFoundLecture');
+    }
+
     return new LectureDetailDto(lecture);
   }