Add datatag to ConnectQueryKey so queryClient can infer type info #532
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Paul Sachs <[email protected]>
|
We have an open question for this change. We can enforce that all ConnectQueryKeys have this type parameter or just make |
Signed-off-by: Paul Sachs <[email protected]>
|
I went with an in-between option, I require a param on |
Signed-off-by: Paul Sachs <[email protected]>
Signed-off-by: Paul Sachs <[email protected]>
Signed-off-by: Paul Sachs <[email protected]>
Signed-off-by: Paul Sachs <[email protected]>
paul-sachs
changed the title
paul-sachs
changed the title
paul-sachs
commented
May 20, 2025
Signed-off-by: Paul Sachs <[email protected]>
Signed-off-by: Paul Sachs <[email protected]>
Signed-off-by: Paul Sachs <[email protected]>
paul-sachs
added a commit
that referenced
this pull request
May 22, 2025
## What's Changed * Add datatag to ConnectQueryKey so queryClient can infer type info by @paul-sachs in #532 ## New Contributors * @guspan-tanadi made their first contribution in #537 **Full Changelog**: v2.0.1...v2.1.0 Signed-off-by: Paul Sachs <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By adding DataTag annotations to the ConnectQueryKey, QueryClient methods can now infer the return type when calling things like
getQueryDataorinvalidateQueries.This is at least a partial alternative to #468 which provides better inference abilities while keeping our api surface smaller. There may still be value down the line with very well defined query client methods but I suspect this change covers 90% of the current use cases.