Use non-deprecated span attributes #184
Conversation
- `net.peer.name` -> replaced with `server.address` on client spans and `client.address` on server spans. - `net.peer.port` -> replaced with `server.port` on client spans and `client.port` on server spans. - `http.status_code` -> replaced with `http.response.status_code`. Signed-off-by: Kason Braley <[email protected]>
| return []attribute.KeyValue{ | ||
| semconv.NetPeerNameKey.String(host), | ||
| semconv.NetPeerPortKey.Int(portInt), |
There was a problem hiding this comment.
For backwards compatibility could we keep the current deprecated attributes too?
There was a problem hiding this comment.
How would you like statusCodeAttribute to behave now? Would you like to have it return a slice of both now instead of just the one attribute.KeyValue?
There was a problem hiding this comment.
Oh yeah that is a bit of an issue, maybe the signature could be changed to append the values or return an array?
There will be a few testcases that require updating from these changes. Mind going through and updating each?
There was a problem hiding this comment.
Sounds goo. Yes I noticed that as well, should have ran the tests locally before opening the PR, that's my bad. I'll tackle the tests, might take me some time as there is a lot to update. Thanks!
Closes #129.
net.peer.name-> replaced withserver.addresson client spans andclient.addresson server spans.net.peer.port-> replaced withserver.porton client spans andclient.porton server spans.http.status_code-> replaced withhttp.response.status_code.