Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: added velodrome test #2

Merged
merged 13 commits into from
Dec 14, 2023
Merged

fix: added velodrome test #2

merged 13 commits into from
Dec 14, 2023

Conversation

prathmeshkhandelwal1
Copy link
Contributor

  • Added Valindrome Proposal.

@LayneHaber LayneHaber self-requested a review November 3, 2023 03:00
@LayneHaber
Copy link
Contributor

Need to add in RPC URLs for CI

@LayneHaber LayneHaber changed the title fix: added Valindrome test fix: added velodrome test Nov 3, 2023
LayneHaber
LayneHaber reviewed Nov 3, 2023
View reviewed changes
Copy link
Contributor

@LayneHaber LayneHaber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see above comment re: ci

@prathmeshkhandelwal1
Copy link
Contributor Author

Need to add in RPC URLs for CI

Should I go ahead and atleast add for all mainnet networks?

@LayneHaber
Copy link
Contributor

Need to add in RPC URLs for CI

Should I go ahead and atleast add for all mainnet networks?

Yes, but not any of the ones we actually use in production environments. Can be all free-tier. May make CI finicky, but we can deal with that

@prathmeshkhandelwal1
Copy link
Contributor Author

Need to add in RPC URLs for CI

Should I go ahead and atleast add for all mainnet networks?

Yes, but not any of the ones we actually use in production environments. Can be all free-tier. May make CI finicky, but we can deal with that

Sure, Can you give me permissions on this repo, so that I can open settings here and configure env there.

@prathmeshkhandelwal1 prathmeshkhandelwal1 merged commit c07a544 into main Dec 14, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LayneHaber LayneHaber LayneHaber approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@prathmeshkhandelwal1 @LayneHaber