Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add samtools ampliconstats feature #53

Closed
wants to merge 5 commits into from

Conversation

ac55-sanger
Copy link
Contributor

This feature of samtools is only available in it's development branch, hence it cannot be directly used. I have created a separate repo and updated the info in README.md file on how to build and use conda packages for htslib and samtools from their development branch.

This pull request also generates ampliconstats per file basis. Will soon add support to run it against all the files in one go.

ac55-sanger and others added 2 commits June 18, 2020 14:23
Add instructions for teh use of samtools-ampliconstats feature
@sb10
Copy link
Contributor

sb10 commented Jun 22, 2020

Since this requires special installation for dev samtools, if that can't be integrated cleanly into this repo, ampliconstats will need to be made an option, so it doesn't break the existing tests.
Ideally a test should be added for ampliconstats mode, if it's possible to install dev samtools as part of the test script.

Add an option to run ampliconstats (samtools development branch)
Run ampliconstats (samtools developement branch) if passed as a parameter (--ampliconstats)
@ac55-sanger
Copy link
Contributor Author

Added a parameter under illumina conf to run ampliconstats (samtools development branch) if "--ampliconstats" flag is passed.

@sb10
Copy link
Contributor

sb10 commented Jun 22, 2020

Thanks @ac55-sanger . Unfortunately the tests are now failing for some reason that doesn't seem related to your changes? It's failing the installation of nextflow using conda.

Can you try and replicate this by running .github/scripts/install_conda.sh and then

export PATH=/opt/conda/bin:$PATH
conda install -c bioconda nextflow
NXF_VER=20.03.0-edge nextflow -version

@m-bull
Copy link
Contributor

m-bull commented Jun 22, 2020

@sb10 - suggest installing Miniconda3 for tests: 319ca24

@ac55-sanger
Copy link
Contributor Author

@sb10 Followed the steps and it fails due to multiple conflicts.

@m-bull 's commit fixes it, just tested:

$NXF_VER=20.03.0-edge nextflow -version
CAPSULE: Downloading dependency io.nextflow:nf-tower:jar:20.03.0-edge
CAPSULE: Downloading dependency io.nextflow:nf-commons:jar:20.03.0-edge
CAPSULE: Downloading dependency io.nextflow:nf-httpfs:jar:20.03.0-edge
CAPSULE: Downloading dependency io.nextflow:nextflow:jar:20.03.0-edge
CAPSULE: Downloading dependency jline:jline:jar:2.14.6
33 KB
N E X T F L O W
version 20.03.0-edge build 5288
created 28-03-2020 11:10 UTC
cite doi:10.1038/nbt.3820
http://nextflow.io

Add --ampliconstats flag info
@ac55-sanger
Copy link
Contributor Author

Added support to run ampliconstats on all the files in one got under:
#58

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants