-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(node): new voting reactor state machine #1136
base: main
Are you sure you want to change the base?
Conversation
Co-authored-by: raulk <[email protected]>
Co-authored-by: raulk <[email protected]>
…/ipc into validator-gating
Co-authored-by: Karel Moravec <[email protected]>
…ard/ipc into collateral-sourcing
…at/topdown-enchancement
/// } | ||
/// TODO: Soft and Hard recovery mode to be added | ||
pub enum OperationStateMachine { | ||
Paused(PausedOperationMode), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I found the Paused
naming to be misleading, because it only relates to the state of the votes publishing (I assume), while other operations are still running. What about Sync
/Syncing
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Paused
could be triggered by many other condition, mostly not just in syncing. Just not implemented yet.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What I mean is that Paused
isn't really idle, so this name is a bit confusing. I didn't refer to what triggers that mode, but to how it's best to describe it (given what it's doing).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Paused pauses the handling internal events.
If we want to change the name, I'm open to any better naming but I feel Idle is not much different either. think we can do this from the doc first or at the final PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't suggest a rename to Idle
, but rather that Paused
suggests a state of idleness, while that's not the case.
Which doc are you referring to?
This PR is the start of in total 4 PRs that implements the new topdown flow. The implementation is broken down as follows:
Paused -> Active -> Paused
. The other two recovery modes are yet to be implemented.For this PR, the key changes are:
Active
andPaused
operation modeTopDownSyncEvent
The state machine is as follow: