Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: filter event by contract #798

Merged
merged 1 commit into from
Mar 15, 2024
Merged

FIX: filter event by contract #798

merged 1 commit into from
Mar 15, 2024

Conversation

cryptoAtwill
Copy link
Contributor

@cryptoAtwill cryptoAtwill commented Mar 15, 2024

Closes ENG-785.

This PR fixes a bug from calling ethers event query. Currently the contract address is not specified, which means other subnets' events can be queried as well or even attackers faking events. This PR solves this issue by fixing the contract address.

@cryptoAtwill cryptoAtwill requested review from aakoshh and raulk March 15, 2024 10:30
Copy link

linear bot commented Mar 15, 2024

@raulk raulk merged commit 3b2e156 into main Mar 15, 2024
19 checks passed
@raulk raulk deleted the filter-by-contract branch March 15, 2024 11:20
Copy link
Contributor

@aakoshh aakoshh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants