fix: missing enum variant for StakingOperation. #805
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Problem The IPC API module was missing enum variant StakingOperation#SetFederatedPower. The fallback branch of the u8 to enum ended up representing unrecognized ABI values as SetMetadata operations. Consequently, SetFederatedPower commands were being wrongly translated and applied in the subnet gateway as SetMetadata commands. Solution Add the missing enum variant and make the conversion typesafe by using try_from. To avoid being pedantic, use num_enum macros. This create was anyway part of the build graph already, so we might as well use it. Credits Shoutout to @mikevoronov and @folex from Fluence Labs for reporting this!
|
Merging this myself, as main is strictly worse off without this fix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The IPC API module was missing enum variant StakingOperation#SetFederatedPower. The fallback branch of the u8 to enum ended up representing unrecognized ABI values as SetMetadata operations. Consequently, SetFederatedPower commands were being wrongly translated and applied in the subnet gateway as SetMetadata commands.
Solution
Add the missing enum variant and make the conversion typesafe by using try_from. To avoid being pedantic, use num_enum macros. This create was anyway part of the build graph already, so we might as well use it.
Credits
Shoutout to @mikevoronov and @folex from Fluence Labs for finding and reporting this!