Adjust context help alignment for consistent indentation #55
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| } else { | ||
| // Multi-line or partial selection | ||
| const firstSelLine = document.lineAt(selection.start.line); | ||
| const preservedPrefix = document.getText(new vscode.Range(firstSelLine.range.start, selection.start)); | ||
| const leadingWS = firstSelLine.text.match(/^[\t ]*/)?.[0] ?? ""; | ||
|
|
||
| // 1) Normalize snippet to avoid duplicating "."/";" according to the prefix that will remain in the file | ||
| formattedTextExpression = normalizeInsertionWithPrefix(formattedTextExpression, preservedPrefix, eol); | ||
|
|
||
| // 2) Only prefix indentation if the selection started at column 0 (i.e., NO preserved prefix) | ||
| formattedTextExpression = maybePrefixFirstLineIndent( | ||
| formattedTextExpression, | ||
| preservedPrefix.length === 0 ? leadingWS : "", | ||
| eol | ||
| ); | ||
|
|
||
| rangeToReplace = new vscode.Range(selection.start, selection.end); | ||
| const start = document.lineAt(selection.start.line).range.start; | ||
| const replacementEnd = contextInfo.replacementEnd ?? document.lineAt(selection.end.line).range.end; | ||
| rangeToReplace = new vscode.Range(start, replacementEnd); |
There was a problem hiding this comment.
For non-empty selections the new logic builds start from document.lineAt(selection.start.line).range.start and uses contextInfo.replacementEnd for the end, so the replacement range always spans whole lines. Because getContextExpressionInfo also returns the text from the start of the first line through the end of the last line, invoking context help on a partial selection now replaces code that lies before or after the selected text. In the previous version rangeToReplace was new vscode.Range(selection.start, selection.end), so only the user’s selection was overwritten. This regression will delete unrelated code whenever the command is run on a substring within a line.
Useful? React with 👍 / 👎.
This pull request corrects the indentation logic in the context help display to ensure consistent alignment between text lines.
It refactors the whitespace handling and improves the visual structure of the context help content.