Improvements to GitHub Actions #1714
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Use the base Ubuntu image for most of the work * Use addnab/docker-run-action@v3 to run the docker image * 🐎 Reuse Ivy caching * Minor label improvements
antares1470
requested changes
Jun 8, 2022
Make sure the checked out code is in a sub folder called `constellation`
* Go back to using --mount as the compilation class files were not being picked up because they are in the isoloated volume which isn't visible to the sonar step. * Add a path to the testing libraries dependency which is the same location
|
This pull request is stale because it has been open for 6 months with no activity. Consider reviewing and taking an action on this pull request. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites
Reviewed the checklist
Reviewed feedback from the "Sonar Cloud" bot. Note that you have to wait
for the "CI / Unit Tests") to complete first. Failed Unit tests can be
debugged by adding the label "verbose logging" to the GitHub PR.
Description of the Change
Based on work done in constellation-app/constellation-applications#8 I have updated the GitHub actions here to align with this. Some improvements are as follows:
Alternate Designs
Why Should This Be In Core?
Benefits
The
.ivy2cache was not being restored which meant dependencies were being downloaded in every release. This has been fixed to work which saves 1.5 minutes off the build timeSome quality of life improvements which should make it easier to read the workflows and maintain them in the future
Possible Drawbacks
Verification Process
Applicable Issues