Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/tableview edges links #1874

Closed
wants to merge 6 commits into from

Conversation

Centauri0320001
Copy link
Collaborator

Prerequisites

  • Reviewed the checklist

  • Reviewed feedback from the "Sonar Cloud" bot. Note that you have to wait
    for the "CI / Unit Tests") to complete first. Failed Unit tests can be
    debugged by adding the label "verbose logging" to the GitHub PR.

Description of the Change

Add buttons to view links and edges of a graph in the table view.

Alternate Designs

Why Should This Be In Core?

Adds enhanced functionality for data analytics in the table view.

Benefits

Possible Drawbacks

Verification Process

Applicable Issues

#1859

@Centauri0320001
Copy link
Collaborator Author

This branch contains several experimental changes for this ticket. The following findings are from experimental code changes attempting to implement links to the table view:

Classes that need to be adjusted for links and edges
• Table.java – Populates the columns with data and handles what datatypes are available for the user to view.
• TableToolbar.java - changes for the tableview buttons
• GraphRecordStoreUtilities.java – Naming and references of columns

Extra considerations:
• Selection mode when viewing different elements (I.E. when viewing links/edges) also need to be implemented.

• With the screenshotted code changes there is an indexing issue with the highlighting for the table view links. When clicking on an entry on the table for links, it highlights the transactions based on the order which the transaction was created instead of the order of the links. This means that if you have multiple transactions between nodes and select a link on the table it won’t highlight the right one on the graph. Was unable to find the class that controls the order of highlighting.

• Filtering needs to be implemented for links and edges, but may require further clarification on how it should be implemented (I.E. what options should be available for selection).

Some classes that possibly need to be adjusted to accommodate the addition of links and edges
• ColumnVisibilityContextMenu.java
• CopyMenu.java
• ExportMenu.java
• TableViewPageFactory.java
• SelectionToGraphPlugin.java

Copy link

This pull request is stale because it has been open for 6 months with no activity. Consider reviewing and taking an action on this pull request.

@OrionsGuardian
Copy link
Collaborator

There is a separate PR which implements the functionality that this PR was intending to address.
Refer to #2011

@antares1470 antares1470 deleted the feature/tableview-edges-links branch December 5, 2024 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants