Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Histogram: handle null valued data on Transaction Edge and Link statistics. #2266

Open
wants to merge 17 commits into
base: master
Choose a base branch
from

Conversation

OrionsGuardian
Copy link
Collaborator

@OrionsGuardian OrionsGuardian commented Jan 23, 2025

Prerequisites

  • Reviewed the checklist

  • Reviewed feedback from the "Sonar Cloud" bot. Note that you have to wait
    for the "CI / Unit Tests") to complete first. Failed Unit tests can be
    debugged by adding the label "verbose logging" to the GitHub PR.

Description of the Change

Histogram can now perform Sum, Average, Min, and Max function on Link and Edge Transaction attributes that are defined as nullable numeric data fields.

Alternate Designs

Why Should This Be In Core?

Enhancement

Benefits

Provides functionality to larger data sets.

Possible Drawbacks

There may be cases where a user would prefer a null value to be treated as a value of 0.
But doing so would affect min, max, and average calculations.

Verification Process

Create 2 nodes
Create 4 transactions between them
Set your connection type to Transactions (Display -> Connection Types -> Transactions)
Select 1 transaction and define a custom attribute "LongNullTest" of type long_or_null
Set a value of 10 in that attribute
Select another transaction and set the LongNullTest value to 20
The remaining two transaction should still have null values by default.
Open the Histogram View
Set the Graph Element to "Link".
Set the Category to "Average Transaction Attribute"
Set the Property to "LongNullTest"

Confirm the Histogram now contain a data entry with a correct Property Value of 15.

Test again with the other Categories:
"Sum Transaction Attribute" (correct value should be 30)
"Maximum Transaction Attribute" (correct value should be 20)
"Minimum Transaction Attribute" (correct value should be 10)

Then test again with a mix of transactions going in both directions between two nodes.
and setting the Histogram Graph Element to "Edge"

Applicable Issues

#2260

@OrionsGuardian OrionsGuardian marked this pull request as draft January 29, 2025 04:26
@OrionsGuardian OrionsGuardian marked this pull request as ready for review February 6, 2025 05:43
@OrionsGuardian OrionsGuardian added the verbose-logging test code in CI with verbose output label Feb 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
verbose-logging test code in CI with verbose output
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants