-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Histogram: handle null valued data on Transaction Edge and Link statistics. #2266
Open
OrionsGuardian
wants to merge
17
commits into
master
Choose a base branch
from
enhancement-histogram-total-avg-mix
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Delphinus8821
approved these changes
Feb 6, 2025
|
mimosa2
approved these changes
Feb 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites
Reviewed the checklist
Reviewed feedback from the "Sonar Cloud" bot. Note that you have to wait
for the "CI / Unit Tests") to complete first. Failed Unit tests can be
debugged by adding the label "verbose logging" to the GitHub PR.
Description of the Change
Histogram can now perform Sum, Average, Min, and Max function on Link and Edge Transaction attributes that are defined as nullable numeric data fields.
Alternate Designs
Why Should This Be In Core?
Enhancement
Benefits
Provides functionality to larger data sets.
Possible Drawbacks
There may be cases where a user would prefer a null value to be treated as a value of 0.
But doing so would affect min, max, and average calculations.
Verification Process
Create 2 nodes
Create 4 transactions between them
Set your connection type to Transactions (Display -> Connection Types -> Transactions)
Select 1 transaction and define a custom attribute "LongNullTest" of type long_or_null
Set a value of 10 in that attribute
Select another transaction and set the LongNullTest value to 20
The remaining two transaction should still have null values by default.
Open the Histogram View
Set the Graph Element to "Link".
Set the Category to "Average Transaction Attribute"
Set the Property to "LongNullTest"
Confirm the Histogram now contain a data entry with a correct Property Value of 15.
Test again with the other Categories:
"Sum Transaction Attribute" (correct value should be 30)
"Maximum Transaction Attribute" (correct value should be 20)
"Minimum Transaction Attribute" (correct value should be 10)
Then test again with a mix of transactions going in both directions between two nodes.
and setting the Histogram Graph Element to "Edge"
Applicable Issues
#2260