Use UBI9 base image for container build #586
Conversation
|
@brianwcook; For your awareness - please address CI failures. |
brianwcook
force-pushed
the
use-ubi-base-image
branch
from
cb78687
to
6c3e8a5
Compare
|
I don't see the same build failure locally. I re-ran pip-compile with a clean venv to see if it solves the problem. |
|
/ok-to-test |
brianwcook
force-pushed
the
use-ubi-base-image
branch
2 times, most recently
from
add0ede
to
0f46d9f
Compare
There was a problem hiding this comment.
@brianwcook sorry for the delay, had other duties last week, now I'm back on this. Please rebase onto the latest main HEAD to get rid of the merge commit you have, we don't do merge commits here.
I adjusted the PR description ever so slightly to make it completely clear that this change is driven solely by the need to support access to entitled subscription-based content.
brianwcook
force-pushed
the
use-ubi-base-image
branch
2 times, most recently
from
9947a5a
to
c137979
Compare
brianwcook
force-pushed
the
use-ubi-base-image
branch
from
c137979
to
66052c6
Compare
|
alright how 'bout now? |
brianwcook
force-pushed
the
use-ubi-base-image
branch
from
66052c6
to
562a399
Compare
There was a problem hiding this comment.
This LGTM, I only wonder if we should add a note to the commit message that the need to install subscription-manager comes from konflux-ci/build-definitions#1205.
I don't think it will be very clear to people even after #580 comes in.
This changes the container build to use UBI9 so that it is supportable by a major user (Red Hat) with subscription enabled repositories. The change requires using createrepo_c from PyPyi since the createrepo_c rpm is not distributed as part of the UBI9 content set and it is desireable to keep this image freely redistributable. Chaniging to UBI keeps maintenance to a minimum (just one image flavor) but in the future multiple images could be maintained if required. The subscription-manager package is included to support konflux-ci/build-definitions#1205 and containerbuildsystem#580 where it will be used to obtain TLS certificates to send to authenticate to private repositories. Signed-off-by: Brian Cook <[email protected]>
brianwcook
force-pushed
the
use-ubi-base-image
branch
from
af1deb0
to
ae614df
Compare
added your comment and rebased again. |
1e0e912
Change the container build to use UBI9 to support user access to Red Hat entitled content from the subscription service using the subscription manager tool (which wouldn't work with Rocky Linux). Since
createrepo_cisn't available from the default RPM repos on UBI, install it from pypi instead. This is tied to the WIP/tech-preview RPM prefetching work.Maintainers will complete the following section
Note: if the contribution is external (not from an organization member), the CI
pipeline will not run automatically. After verifying that the CI is safe to run:
/ok-to-test(as is the standard for Pipelines as Code)