Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support --platform parameter in image_from #130

Merged

Conversation

tim-vk
Copy link
Contributor

@tim-vk tim-vk commented Sep 28, 2022

fixes: #124

Maintainers will complete the following section

  • Commit messages are descriptive enough
  • Code coverage from testing does not decrease and new code is covered

Copy link
Contributor

@MartinBasti MartinBasti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the contribution, this somehow failed to appear on our radar, sorry

@rcerven rcerven merged commit ff7bbc9 into containerbuildsystem:master Nov 23, 2022
@rcerven
Copy link
Member

rcerven commented Nov 23, 2022

rn updated

@MartinBasti
Copy link
Contributor

okay, for some reason, GH actions didn't run and it caused CI failures in master branch

./tests/test_parser.py:315:1: W293 blank line contains whitespace
4
./tests/test_parser.py:317:5: E303 too many blank lines (2)

https://github.com/containerbuildsystem/dockerfile-parse/actions/runs/3533487878

I'm fixing it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Base image is incorrect when FROM statement has --platform
3 participants