Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support mkfs for userspace convertor #222

Merged
merged 1 commit into from
Sep 13, 2023
Merged

support mkfs for userspace convertor #222

merged 1 commit into from
Sep 13, 2023

Conversation

liulanzheng
Copy link
Member

@liulanzheng liulanzheng commented Sep 7, 2023

What this PR does / why we need it:

Add an flag --mkfs for userspace convertor, which make ext filesystem in the bottom layer, base layer is not required under this config.
mkfs will be the default config in the feature.
Be carefull, it may be conflict with layer deduplication if reused layers were built without mkfs.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Please check the following list:

  • Does the affected code have corresponding tests, e.g. unit test, E2E test?
  • Does this change require a documentation update?
  • Does this introduce breaking changes that would require an announcement or bumping the major version?
  • Do all new files have an appropriate license header?

@liulanzheng
Copy link
Member Author

@WaberZhuang cc

Copy link
Contributor

@WaberZhuang WaberZhuang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@liulanzheng liulanzheng merged commit e4cc3d9 into containerd:main Sep 13, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants