Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

some enhancements #242

Merged
merged 1 commit into from
Nov 10, 2023
Merged

some enhancements #242

merged 1 commit into from
Nov 10, 2023

Conversation

liulanzheng
Copy link
Member

What this PR does / why we need it:

  • ensure that everlaybd-seal only applies to overlaybd writable layer
  • remove SupportReadWriteMode label after seal
  • always try unmount mountpoint even for rwdev, unmounting a not mounted dir has no side effects for mount.UnmountAll

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Please check the following list:

  • Does the affected code have corresponding tests, e.g. unit test, E2E test?
  • Does this change require a documentation update?
  • Does this introduce breaking changes that would require an announcement or bumping the major version?
  • Do all new files have an appropriate license header?

Copy link
Contributor

@yuchen0cc yuchen0cc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@liulanzheng liulanzheng merged commit 8245172 into containerd:main Nov 10, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants