Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pkg/utils: fix compilation error for Windows #247

Merged
merged 1 commit into from
Nov 24, 2023

Conversation

AkihiroSuda
Copy link
Member

What this PR does / why we need it:
Fixes compilation for WIndows

Required for:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #246

Please check the following list:

  • Does the affected code have corresponding tests, e.g. unit test, E2E test?
  • Does this change require a documentation update?
  • Does this introduce breaking changes that would require an announcement or bumping the major version?
  • Do all new files have an appropriate license header?

Fix issue 246

Signed-off-by: Akihiro Suda <[email protected]>
Copy link
Member

@liulanzheng liulanzheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks

@liulanzheng liulanzheng merged commit 526b680 into containerd:main Nov 24, 2023
6 checks passed
@AkihiroSuda
Copy link
Member Author

Can we get a new release?

@liulanzheng
Copy link
Member

Can we get a new release?

v1.0.2 is ready.

@AkihiroSuda
Copy link
Member Author

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Regression in v1.0.1: Windows: pkg/utils/du_unix.go:37:29: undefined: syscall.Stat_t
2 participants