Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EROFS] Add a check for erofs #306

Merged
merged 1 commit into from
Oct 8, 2024
Merged

[EROFS] Add a check for erofs #306

merged 1 commit into from
Oct 8, 2024

Conversation

salvete
Copy link
Contributor

@salvete salvete commented Oct 8, 2024

Add an additional check to verify whether the host machine truly supports the EROFS file system, and only mount it as the EROFS file system if it is supported.

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Please check the following list:

  • Does the affected code have corresponding tests, e.g. unit test, E2E test?
  • Does this change require a documentation update?
  • Does this introduce breaking changes that would require an announcement or bumping the major version?
  • Do all new files have an appropriate license header?

Add an additional check to verify whether the host machine
truly supports the EROFS file system, and only mount it as
the EROFS file system if it is supported.

Signed-off-by: Hongzhen Luo <[email protected]>
Copy link
Contributor

@WaberZhuang WaberZhuang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, @liulanzheng please take a look and add label ok-to-test for this pr.

@liulanzheng liulanzheng added the ok-to-test Pull request is ok to run ci test label Oct 8, 2024
Copy link
Member

@liulanzheng liulanzheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@liulanzheng liulanzheng merged commit db1d6fc into containerd:main Oct 8, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ok-to-test Pull request is ok to run ci test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants