Fixed the issue that a new output tag would not be uploaded if a cach… #311
Conversation
|
Thanks for the PR, please add your signature to the commit to pass the project check. @estebanreyl Please take a look at this. |
| } | ||
| // ensure that output tag is pushed even if the manifest is already converted and found in registry | ||
| // push output tag only if the pusher is tagPusher | ||
| if err := uploadBytes(ctx, b.pusher, convertedDesc, cbuf); err != nil { |
There was a problem hiding this comment.
Have you tested this out? It is my expectation that this will fail to push as you are serializing the descriptor rather than the manifest itself.
There was a problem hiding this comment.
I was working on this in parallel it seems, so this shows what I mean: 2ac3a12.
…e was found in the database during the dup convert process. Signed-off-by: fourierrr <[email protected]>
|
@estebanreyl sorry，i found my mistake yesterday night😂，and repush just now. I found that your approach to the fix is similar to mine, but yours is more intuitive and elegant. I will close this PR. |
|
@fourierrr sounds good. Thanks again for the PR and opening the issue, I should've opened it up as soon as we were aware rather than waiting to avoid the double work. I'll try to do better in this regard moving forward. Anyway, I greatly appreciate your proactivity and contributions to the project. I will try to open a PR with my changes tomorrow, I think the changes are functional but need to add some testing and do some additional validation. |
…e was found in the database during the dup convert process.
What this PR does / why we need it:
Fixed the issue that a new output tag would not be uploaded if a cache was found in the database during the dup convert process.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #310
Please check the following list: