Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bugfix] convertor: turbo error when vsize != 64 #313

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

WaberZhuang
Copy link
Contributor

What this PR does / why we need it:
All overlaybd image layers should be in the same virtual size, but there was something wrong with userspace convertor (turbo only), which resulting in layers with inconsistent virtual size. We can easily reproduce the error with following command:

/opt/overlaybd/snapshotter/convertor -r localhost:5000/redis -i 7.2.3 --turboOCI 7.2.3_turbo_256 --vsize 256
# converted image '7.2.3_turbo_256' can't work

This bug occurs when converting TurboOCI and --vsize is greater than 64.

Otherwise, the project-check workflow is broken due to newer go version. It has been fixed in this PR.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Please check the following list:

  • Does the affected code have corresponding tests, e.g. unit test, E2E test?
  • Does this change require a documentation update?
  • Does this introduce breaking changes that would require an announcement or bumping the major version?
  • Do all new files have an appropriate license header?

@yuchen0cc yuchen0cc added the ok-to-test Pull request is ok to run ci test label Oct 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ok-to-test Pull request is ok to run ci test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants