Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: don't log ENOTSUP during parsing PSI files #321

Merged
merged 1 commit into from
Jan 4, 2024

Conversation

KimMachineGun
Copy link
Contributor

Currently, the PSI parsing code records error logs when PSI is disabled.
This update ensures that only error logs are recorded, except when the error is unix.ENOTSUP.

Other Projects:

@KimMachineGun
Copy link
Contributor Author

Related to #308.
cc. @dmcgowan @fuweid @zouyee

Copy link
Member

@fuweid fuweid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fuweid fuweid merged commit 1a0f8bf into containerd:main Jan 4, 2024
8 checks passed
@KimMachineGun
Copy link
Contributor Author

@fuweid May I know the release plan for the next version, which includes these changes?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants