Added aria-label tags for twitter image in home page #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: surya474 <[email protected]>
Signed-off-by: surya474 <[email protected]>
surya474
force-pushed
the
accessibility-alt
branch
2 times, most recently
from
5ea5157 to
461b4fe
Compare
AkihiroSuda
approved these changes
Oct 28, 2019
estesp
reviewed
Oct 28, 2019
| @@ -64,7 +64,7 @@ | |||
| <hr class="hr has-background-grey"> | |||
|
|
|||
| <div class="buttons"> | |||
| <a class="button has-background-twitter-blue is-borderless has-text-white" href="{{ $twitterUrl }}"> | |||
| <a class="button has-background-twitter-blue is-borderless has-text-white" aria-label="Know more in twitter" href="{{ $twitterUrl }}"> | |||
| @@ -73,7 +73,7 @@ | |||
| </span> | |||
| </a> | |||
|
|
|||
| <a class="button is-borderless has-background-black has-text-white" href="{{ $githubUrl }}"> | |||
| <a class="button is-borderless has-background-black has-text-white" aria-label="Know more in Github" href="{{ $githubUrl }}"> | |||
| @@ -72,13 +72,13 @@ | |||
| <div class="navbar-item"> | |||
| <div class="field is-grouped"> | |||
| <p class="control"> | |||
| <a class="button has-background-twitter-blue is-borderless has-text-white" href="{{ $twitterUrl }}"> | |||
| <a class="button has-background-twitter-blue is-borderless has-text-white" aria-label="Know more in twitter" href="{{ $twitterUrl }}"> | |||
| <span class="icon"> | ||
| <i class="fab fa-twitter" aria-hidden="true"></i> | ||
| </span> | ||
| </a> | ||
|
|
||
| <a class="button is-borderless has-background-black has-text-white" href="{{ $githubUrl }}"> | ||
| <a class="button is-borderless has-background-black has-text-white" aria-label="Know more in Github" href="{{ $githubUrl }}"> |
dmcgowan
requested changes
Dec 3, 2019
|
ping @surya474 please update the wording |
|
ping @surya474 could you;
|
|
Closing due to inactivity, feel free to re-open the pull request anytime if you continue working on this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: surya474 [email protected]
Related to issue