Fix dead link for bandwidth plugin comment #79
Conversation
Codecov Report
@@ Coverage Diff @@
## main #79 +/- ##
==========================================
+ Coverage 42.23% 43.91% +1.68%
==========================================
Files 9 9
Lines 367 378 +11
==========================================
+ Hits 155 166 +11
Misses 181 181
Partials 31 31
Continue to review full report at Codecov.
|
Signed-off-by: Michael Zappa <[email protected]>
MikeZappa87
force-pushed
the
issue/deadlink
branch
from
349ab2e to
4f53315
Compare
| @@ -34,7 +34,7 @@ func WithCapabilityIPRanges(ipRanges []IPRanges) NamespaceOpts { | |||
| } | |||
|
|
|||
| // WithCapabilityBandWitdh adds support for traffic shaping: | |||
| // https://github.com/heptio/cni-plugins/tree/master/plugins/meta/bandwidth | |||
| // https://github.com/containernetworking/plugins/tree/master/plugins/meta/bandwidth | |||
There was a problem hiding this comment.
Does this plugin work correctly today with this library?
There seems to be a mismatch in the json fields
https://github.com/containernetworking/plugins/blob/master/plugins/meta/bandwidth/main.go#L40
and
There was a problem hiding this comment.
Is this referring to the missing json annotations in the types.go file? I am tracing the code path in the cni,go-cni and contained repos.
There was a problem hiding this comment.
right should check if all is well after we changed it from int to uint64 here in go-cni.. but kept pointing to hepatio... as a service question
|
needs a rebase |
|
@MikeZappa87 if this is still valid, we should get this in..looks like it fell between the cracks |
|
Maybe I should get this done! |
Resolving a dead link for the bandwidth plugin.
Resolves Issue:
#78