Add build tag no_ipfs
#4381
Open
Add build tag no_ipfs
#4381
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
``` BUILDTAGS=no_ipfs make ``` Discussed in issue 1986 Signed-off-by: Akihiro Suda <[email protected]>
This was referenced Jun 27, 2025
apostasie
reviewed
Jun 27, 2025
| @@ -99,3 +99,12 @@ jobs: | |||
| build linux s390x | |||
| [ ! "$failure" ] || exit 1 | |||
| - if: ${{ env.GO_VERSION != '' }} | |||
| name: "Run: make binaries with csustom BUILDTAGS" | |||
apostasie
reviewed
Jun 27, 2025
| endif | ||
| GO_BUILDTAGS ?= | ||
| GO_TAGS=$(if $(GO_BUILDTAGS),-tags "$(strip $(GO_BUILDTAGS))",) | ||
|
|
There was a problem hiding this comment.
Do we need the extra GO_BUILDTAGS variable?
Would below just work / be simpler?
BUILDTAGS ?=
GO_TAGS=$(if $(BUILDTAGS),-tags "$(strip $(BUILDTAGS))",)
apostasie
approved these changes
Jun 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Discussed in: