fix: allow storing additional network info in network-config.json #4385
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AkihiroSuda
reviewed
Jun 27, 2025
| @@ -55,26 +55,30 @@ func New(dataStore, namespace, containerID string) (ns *NetworkStore, err error) | |||
| }, nil | |||
| } | |||
|
|
|||
| type NetworkConfig struct { | |||
| PortMappings []cni.PortMapping | |||
There was a problem hiding this comment.
Oh, sorry, I'll add json tag.
AkihiroSuda
reviewed
Jun 27, 2025
When we specify the `-p` option with `nerdctl run`, etc., the port mapping information is stored in the following `network-config.json`. ``` <DATAROOT>/<ADDRHASH>/containers/<NAMESPACE>/<CID>/network-config.json ``` However, the current implementation can only store port mapping information and does not have the extensibility to store other network-related information. This point was feedback in the following PR. - containerd#4376 Therefore, this commit updates the `network-config.json` to allow for the expansion of the information that can be stored. Signed-off-by: Hayato Kiwata <[email protected]>
haytok
force-pushed
the
followup_of_issue_4027
branch
from
f527009 to
59890cb
Compare
apostasie
approved these changes
Jun 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details are described in commits.