Add chunk-dedup flag to support local cas chunk deduplication. #519
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #519 +/- ##
==========================================
- Coverage 37.81% 37.70% -0.11%
==========================================
Files 60 60
Lines 7090 7163 +73
==========================================
+ Hits 2681 2701 +20
- Misses 4097 4149 +52
- Partials 312 313 +1
|
config/config.go
Outdated
| @@ -326,6 +327,10 @@ func ParseParameters(args *flags.Args, cfg *SnapshotterConfig) error { | |||
| daemonConfig.FsDriver = args.FsDriver | |||
| } | |||
|
|
|||
| if args.ChunkDedup { | |||
There was a problem hiding this comment.
You can not only check if this option is true because the case of --chunk-dedup=false is omitted.
Please refer to the pull request at #391.
config/daemonconfig/fscache.go
Outdated
| @@ -45,6 +45,10 @@ type FscacheDaemonConfig struct { | |||
| CacheConfig struct { | |||
| WorkDir string `json:"work_dir"` | |||
| } `json:"cache_config"` | |||
| DedupConfig struct { | |||
pkg/daemon/daemon.go
Outdated
| @@ -260,6 +262,15 @@ func (d *Daemon) sharedFusedevMount(rafs *Rafs) error { | |||
| return errors.Wrap(err, "dump instance configuration") | |||
| } | |||
|
|
|||
| // static dedup bootstrap | |||
| if d.States.ChunkDedup { | |||
| log.L.Infoln("sharedFusedevMount, cfg = ", cfg) | |||
There was a problem hiding this comment.
Please avoid printing too many logs. I suppose Debug level is more reasonable.
| @@ -118,6 +120,10 @@ type DeviceConfig struct { | |||
| DisableIndexedMap bool `json:"disable_indexed_map"` | |||
| } `json:"config"` | |||
| } `json:"cache"` | |||
| Dedup struct { | |||
| Enable bool `json:"enable"` | |||
| WorkDir string `json:"work_dir"` | |||
There was a problem hiding this comment.
Is this WorkDir option redundant? Otherwise, it should be exported as well to the configuration file.
There was a problem hiding this comment.
Is this
WorkDiroption redundant? Otherwise, it should be exported as well to the configuration file.
Nydusd needs WorkDir to specify the location of the CAS database. "Exported to the configuration file" means to dump WorkDir into the config file passed to nydusd?
Signed-off-by: xwb1136021767 <[email protected]>
|
Need rebase. 😉 |
Add chunk-dedup flag to support local cas chunk deduplication. If you want to enable the local cas chunk deduplication function, start nydus-snapshotter with
--chunk-dedupflag and add dedup related configurations to the nydus configuration file.example: