Add info from Github pull requests and security advisories #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add highlights to template and option to use highlights Signed-off-by: Derek McGowan <[email protected]>
estesp
reviewed
Nov 1, 2023
| } | ||
| } | ||
| } | ||
| req, err := http.NewRequest("GET", u, nil) |
There was a problem hiding this comment.
minor and probably a follow-on cleanup, but this is the 2nd instance of setting up an HTTP API call to GH with API version, auth, error handling; might be worth extracting to a function so if the headers/API version needs an update in the future it's easy to do in one place.
There was a problem hiding this comment.
Yeah we can, originally they were slightly different because the API docs seemed to be updated since I started working on it. Good reason to have it once.
estesp
approved these changes
Nov 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add highlights to template and option to use highlights.
This pull requests uses labels on the pull requests to get the highlight changelog lines and group the changes based on the
area/labels. It recognizesimpact/changelog,impact/breaking, andimpact/deprecation. It also adds a security category for Github Security Advisories.