Fix release tool issues #48
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Derek McGowan <[email protected]>
Signed-off-by: Derek McGowan <[email protected]>
austinvazquez
approved these changes
Mar 7, 2024
akhilerm
reviewed
Mar 7, 2024
| @@ -415,7 +415,8 @@ This tool should be ran from the root of the project repository for a new releas | |||
| r.Dependencies = updatedDeps | |||
| if highlights { | |||
| r.Highlights = groupHighlights(projectChanges) | |||
| } else { | |||
| } | |||
| if !highlights || !skipCommits { | |||
There was a problem hiding this comment.
This will cause the commits to be displayed even if the --skip-commits is set to true, but highlights flag is not set, it defaults to false.
There was a problem hiding this comment.
If skip-commits is set, then commits are ignored and not listed, only PRs are. Highlights also only shows PRs. If highlights is set, then it doesn't make sense to also show just the full of PRs below the highlights. Documentation probably makes more sense here, I'll at least update the flags to use on our own release docs.
akhilerm
approved these changes
Mar 7, 2024
estesp
approved these changes
Mar 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix an issue with
]not getting stripped in titles like[release/1.6]Fix an issue where the changelog with commits its not included when highlights flag is set even though skip commits is not set.