-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bump wasmedge-sdk from 0.13.2 to 0.14.0 #777
Conversation
466fbfd
to
e037056
Compare
@CaptainVincent , do you know why the returned |
Not sure yet, I'm still looking into this part. |
I've been looking into this. The code reaches the I'm not sure what could be leading to a segmentation fault inside the C++ codebase. |
I have tried to simplify the part where I integrate WasmEdge and run it in a pure environment. Based on cross-validation, it seems that some configurations are missing in the integration part. I will fix the exit code issue as soon as possible. The Windows part is more complicated, and I'm not sure if the issue is related to the FFI generated by bindgen, because based on my inspection, there doesn’t seem to be much difference in the headers for the release across different platforms. |
2b8f74b
to
b1df4e4
Compare
I think the windows issue is due to the wrong WasmEdge version installed in CI. |
@CaptainVincent , do you know what changed? Why is it working now? |
ab0e0fd
to
678a862
Compare
To avoid crashes, I temporarily removed the following: PluginManager::load(None)?;
PluginManager::auto_detect_plugins()?; I will submit a separate PR to add support for the plugin feature. Currently, I am still debugging this functionality, which is needed to support plugins like wasi_nn and similar. -- Additionally, I modified the setup-windows.sh script, but it still doesn’t seem to work for windows ci. Could it be that some caching mechanisms are causing the issue to persist? Because the Windows lint is working. |
The corresponding WasmEdge lib release is 0.14.1 Signed-off-by: vincent <[email protected]>
678a862
to
d7abdd3
Compare
The previous force push failure related to Windows really seems to be about the cached issue. After I rebase it, it's all good now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
The corresponding WasmEdge lib release is 0.14.1.