-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Benchmark memory #808
Benchmark memory #808
Conversation
Signed-off-by: Jorge Prendes <[email protected]>
Signed-off-by: Jorge Prendes <[email protected]>
Signed-off-by: Jorge Prendes <[email protected]>
2886ac0
to
4342042
Compare
Signed-off-by: Jorge Prendes <[email protected]>
6c46fbc
to
4a89ced
Compare
Here's how the benchmark shows in CI
|
Nice! At what point in the process’s lifetime we take a snapshot of memory usage? IIUC, those values represent the peak usage during the process’s runtime, so ideally we should capture the snapshot just before terminating the process? |
Indeed, the snapshot is taken after shutting down the shim server, just before exiting the main function. |
And yes, they represent peak usage as reported by the kernel. |
Signed-off-by: Jorge Prendes <[email protected]>
This PR adds a memory usage benchmark to CI.
Fixes #802 , at least for the single container use case.
The PR is based on #775, I'll rebase once that is merged.Marking as draft until then.