Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize: refine the scope of the lock. #350

Merged
merged 3 commits into from
Dec 15, 2024
Merged

Conversation

jokemanfire
Copy link
Contributor

We can discard the lock before reporting the incident.According to Goshim.

@github-actions github-actions bot added the C-runc-shim Runc shim label Dec 4, 2024
crates/runc-shim/src/task.rs Outdated Show resolved Hide resolved
No need to wait for runc return an error

Signed-off-by: jokemanfire <[email protected]>
Copy link
Member

@mxpv mxpv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@mxpv mxpv added this pull request to the merge queue Dec 13, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to a conflict with the base branch Dec 13, 2024
@mxpv
Copy link
Member

mxpv commented Dec 13, 2024

Looks like this needs to be rebased before merging.

We can discard the lock before reporting the incident.According to Goshim.

Signed-off-by: jokemanfire <[email protected]>
@mxpv mxpv added this pull request to the merge queue Dec 15, 2024
Merged via the queue into containerd:main with commit 4133fef Dec 15, 2024
18 checks passed
@jokemanfire jokemanfire deleted the lockdev branch December 15, 2024 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-runc-shim Runc shim
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants