OpenOptions in blocking mod is a time-consuming operation. #359
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jokemanfire
force-pushed
the
io
branch
2 times, most recently
from
09d88aa to
7257a45
Compare
mxpv
reviewed
Jan 8, 2025
|
Overall looks good! I have one minor comment. |
1.Prevent it from blocking a tokio thread. Change sync to async. 2.Add pipe unit test which I found error in Pipe new. Signed-off-by: jokemanfire <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prevent it from blocking a tokio thread. Change sync to async.
And fix an error in Pipe struct.