add doc for deploy with systemd #307
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chenk008
force-pushed
the
add_doc_for_deploy
branch
from
62a915c
to
f10d13c
Compare
|
Also, please squash the commits and sign it with your real name. |
chenk008
force-pushed
the
add_doc_for_deploy
branch
2 times, most recently
from
c030138
to
f076c7d
Compare
ktock
reviewed
Apr 22, 2021
chenk008
force-pushed
the
add_doc_for_deploy
branch
2 times, most recently
from
ac77830
to
bc39212
Compare
AkihiroSuda
reviewed
Apr 23, 2021
docs/deploy.md
Outdated
| ``` | ||
| tar -xvf stargz-snapshotter-${version}-linux-${arch}.tar.gz -C /usr/local/bin | ||
| wget -O /etc/systemd/system/stargz-snapshotter.service https://raw.githubusercontent.com/containerd/stargz-snapshotter/master/script/config/etc/systemd/system/stargz-snapshotter.service | ||
| systemctl enable stargz-snapshotter |
There was a problem hiding this comment.
Refact to `systemctl enable --now
`
AkihiroSuda
reviewed
Apr 23, 2021
docs/deploy.md
Outdated
|
|
||
| ###### centos | ||
| ``` | ||
| yum install fuse |
AkihiroSuda
reviewed
Apr 23, 2021
docs/deploy.md
Outdated
| @@ -0,0 +1,47 @@ | |||
| # Deploy Stargz Snapshotter | |||
There was a problem hiding this comment.
The file name should be INSTALL.md , and should be linked from README.md: https://github.com/containerd/stargz-snapshotter#quick-start-with-kubernetes
There was a problem hiding this comment.
Put kubernetes section into INSTALL.md too, add link in README.md
ktock
requested changes
Apr 26, 2021
|
@chenk008 Thanks for fixing the doc. Please fix whitespace errors reported by CI, squash the commits and sign the commit. |
chenk008
force-pushed
the
add_doc_for_deploy
branch
from
f6fc87b
to
bb0c657
Compare
|
@ktock I have fixed these errors. Please take a look |
|
@chenk008 Please fix whitespace errors reported by |
AkihiroSuda
reviewed
Apr 27, 2021
AkihiroSuda
reviewed
Apr 27, 2021
AkihiroSuda
reviewed
Apr 27, 2021
chenk008
force-pushed
the
add_doc_for_deploy
branch
2 times, most recently
from
719525f
to
1041d4c
Compare
ktock
approved these changes
May 7, 2021
chenk008
force-pushed
the
add_doc_for_deploy
branch
from
1041d4c
to
7fd52b6
Compare
Signed-off-by: chenkang <[email protected]>
chenk008
force-pushed
the
add_doc_for_deploy
branch
from
7fd52b6
to
b8f3b58
Compare
ktock
approved these changes
May 10, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is systemd service config, but lacks of deployment document.
I suggest that we can write a document to describe how to deploy stargz-snapshotter on different platforms such as Systemd, Kubernetes, AWS