Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[0.6.0] Ignore close fd error #215

Closed

Conversation

Tim-Zhang
Copy link
Member

No description provided.

@codecov
Copy link

codecov bot commented Oct 23, 2023

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (a42b31c) 11.70% compared to head (f031f98) 11.59%.
Report is 1 commits behind head on 0.6.0.

Additional details and impacted files
@@            Coverage Diff             @@
##            0.6.0     #215      +/-   ##
==========================================
- Coverage   11.70%   11.59%   -0.11%     
==========================================
  Files          13       12       -1     
  Lines        1547     1552       +5     
==========================================
- Hits          181      180       -1     
- Misses       1366     1372       +6     
Files Coverage Δ
src/sync/server.rs 0.00% <0.00%> (ø)

... and 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

We can't avoid file descriptors being mistakenly closed by other code.
So in this case, the only thing we can do is ignore errors.

Signed-off-by: Tim Zhang <[email protected]>
@Tim-Zhang Tim-Zhang force-pushed the ignore-close-fd-error-0.6 branch from 8bdc174 to f6e104a Compare October 23, 2023 12:31
@Tim-Zhang
Copy link
Member Author

Branch 0.6.0 is deprecated

@Tim-Zhang Tim-Zhang closed this Oct 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant