Add tests #256
Merged
Add tests #256
+59
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cargo fmt --all Fixes: containerd#255 Signed-off-by: Quanwei Zhou <[email protected]>
quanweiZhou
force-pushed
the
add-tests
branch
2 times, most recently
from
2487554 to
9ff0722
Compare
add debug info for tests Fixes: containerd#255 Signed-off-by: Quanwei Zhou <[email protected]>
quanweiZhou
force-pushed
the
add-tests
branch
2 times, most recently
from
0fe539d to
a4f9323
Compare
check client fd leak Fixes: containerd#255 Signed-off-by: Quanwei Zhou <[email protected]>
wllenyj
approved these changes
Oct 8, 2024
It's important for windows to fail correctly. Further: actions/runner-images#6668 Signed-off-by: Tim Zhang <[email protected]>
By removing sleep from client.rs, and remoing retry. Signed-off-by: Tim Zhang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
enhance tests for client FD leak check
Fixes: #255