go.mod: restore the support for Go 1.22 #1108
Open
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as resolved.
This comment was marked as resolved.
|
@squeed Could you take a look? |
austinvazquez
approved these changes
Oct 22, 2024
|
@squeed did we move to 1.23 for a specific reason? If not does it make sense to bring it back to 1.22? |
Go 1.22 is still actively maintained. Signed-off-by: Akihiro Suda <[email protected]>
s1061123
reviewed
Jan 6, 2025
| @@ -1,6 +1,6 @@ | |||
| module github.com/containernetworking/plugins | |||
|
|
|||
| go 1.23 | |||
| go 1.22.0 | |||
There was a problem hiding this comment.
I agree with you @AkihiroSuda , but how about to change go 1.22? Is there any strong reason why we use 1.22.0?
|
I filed #1133 to make a separate go version file for CI. Then we can merge this :-). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Go 1.22 is still actively maintained.