Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump Go version to 1.23 in scripts/release.sh #1123

Merged
merged 1 commit into from
Jan 6, 2025

Conversation

jingyuanliang
Copy link
Contributor

No description provided.

Copy link

@MrHohn MrHohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Seems right to me to match up the version bumped in #1094.
/cc @squeed

Copy link
Contributor

@s1061123 s1061123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good to me. Merge it soon.

BTW, we no longer uses this script file because it is for 'manual release process that is used previously'. Now we use github action to automate process. So this file (scripts/release.sh) will be removed soon. Just FYI.

@s1061123 s1061123 merged commit ba8bc7d into containernetworking:main Jan 6, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants