cli: wipe_ostree in spawn_blocking

An async fn shouldn't block the thread, but write_deployments is a blocking heavy filesystem operation. Using tokio::task::spawn_blocking to avoid blocking async threads. Solves #778 Signed-off-by: Omer Tuchfeld <[email protected]>
containers · Sep 6, 2024 · 0eb8d3b · 0eb8d3b
1 parent 1ba8d1e
commit 0eb8d3b
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 6 deletions.
diff --git a/lib/src/cli.rs b/lib/src/cli.rs
@@ -21,7 +21,6 @@ use ostree_ext::keyfileext::KeyFileExt;
 use ostree_ext::ostree;
 use schemars::schema_for;
 
-use crate::deploy::wipe_ostree;
 use crate::deploy::RequiredHostSpec;
 use crate::lints;
 use crate::spec::Host;
@@ -929,7 +928,7 @@ async fn run_from_opt(opt: Opt) -> Result<()> {
             StateOpts::WipeOstree => {
                 let sysroot = ostree::Sysroot::new_default();
                 sysroot.load(gio::Cancellable::NONE)?;
-                wipe_ostree(&sysroot).await?;
+                crate::deploy::wipe_ostree(sysroot).await?;
                 Ok(())
             }
         },

diff --git a/lib/src/deploy.rs b/lib/src/deploy.rs
@@ -288,10 +288,13 @@ pub(crate) async fn prune_container_store(sysroot: &Storage) -> Result<()> {
     Ok(())
 }
 
-pub(crate) async fn wipe_ostree(sysroot: &Sysroot) -> Result<()> {
-    sysroot
-        .write_deployments(&[], gio::Cancellable::NONE)
-        .context("removing deployments")?;
+pub(crate) async fn wipe_ostree(sysroot: Sysroot) -> Result<()> {
+    tokio::task::spawn_blocking(move || {
+        sysroot
+            .write_deployments(&[], gio::Cancellable::NONE)
+            .context("removing deployments")
+    })
+    .await??;
 
     Ok(())
 }