-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a hidden bootc install wipe-ostree
#776
Comments
To that end @cgwalters suggested we use |
Even while avoiding the let sysroot = ostree::Sysroot::new_default();
sysroot.set_mount_namespace_in_use();
sysroot.load(gio::Cancellable::NONE)?;
sysroot
.write_deployments(&[], gio::Cancellable::NONE)
.context("removing deployments")?; The |
Yeah, removing a deployment doesn't remove a stateroot today. But it should take care of the |
Ah of course, that makes sense. In that case, it seems to have done the job correctly. I'll try to plug it in the tests cleanup function in place of all the |
Nah actually it didn't seem to work:
|
Or maybe it's just due to insufficient mounts, if I do this instead:
it works Maybe the lack of |
Yeah it's that |
Yep confirmed |
Solves containers#776 Right now the integration tests have some hacky code to clear out `ostree` stateroots (see `reset_root` function), it would be better if they could rely on a bootc command to take care of that for them instead This commit adds a new `state wipe-ostree` subcommand to the CLI that removes all `ostree` deployments from the system using native ostree bindings. This makes it easier to later rm -rf the stateroots and have a clean slate for the next test.
Solves containers#776 Right now the integration tests have some hacky code to clear out `ostree` stateroots (see `reset_root` function), it would be better if they could rely on a bootc command to take care of that for them instead This commit adds a new `state wipe-ostree` subcommand to the CLI that removes all `ostree` deployments from the system using native ostree bindings. This makes it easier to later rm -rf the stateroots and have a clean slate for the next test.
Solves containers#776 Right now the integration tests have some hacky code to clear out `ostree` stateroots (see `reset_root` function), it would be better if they could rely on a bootc command to take care of that for them instead This commit adds a new `state wipe-ostree` subcommand to the CLI that removes all `ostree` deployments from the system using native ostree bindings. This makes it easier to later rm -rf the stateroots and have a clean slate for the next test.
Solves containers#776 Right now the integration tests have some hacky code to clear out `ostree` stateroots (see `reset_root` function), it would be better if they could rely on a bootc command to take care of that for them instead This commit adds a new `state wipe-ostree` subcommand to the CLI that removes all `ostree` deployments from the system using native ostree bindings. This makes it easier to later rm -rf the stateroots and have a clean slate for the next test.
Solves containers#776 Right now the integration tests have some hacky code to clear out `ostree` stateroots (see `reset_root` function), it would be better if they could rely on a bootc command to take care of that for them instead This commit adds a new `state wipe-ostree` subcommand to the CLI that removes all `ostree` deployments from the system using native ostree bindings. This makes it easier to later rm -rf the stateroots and have a clean slate for the next test.
Solves containers#776 Right now the integration tests have some hacky code to clear out `ostree` stateroots (see `reset_root` function), it would be better if they could rely on a bootc command to take care of that for them instead This commit adds a new `state wipe-ostree` subcommand to the CLI that removes all `ostree` deployments from the system using native ostree bindings. This makes it easier to later rm -rf the stateroots and have a clean slate for the next test.
Solves containers#776 Right now the integration tests have some hacky code to clear out `ostree` stateroots (see `reset_root` function), it would be better if they could rely on a bootc command to take care of that for them instead This commit adds a new `state wipe-ostree` subcommand to the CLI that removes all `ostree` deployments from the system using native ostree bindings. This makes it easier to later rm -rf the stateroots and have a clean slate for the next test.
Solves containers#776 Right now the integration tests have some hacky code to clear out `ostree` stateroots (see `reset_root` function), it would be better if they could rely on a bootc command to take care of that for them instead This commit adds a new `state wipe-ostree` subcommand to the CLI that removes all `ostree` deployments from the system using native ostree bindings. This makes it easier to later rm -rf the stateroots and have a clean slate for the next test.
Solves containers#776 Right now the integration tests have some hacky code to clear out `ostree` stateroots (see `reset_root` function), it would be better if they could rely on a bootc command to take care of that for them instead This commit adds a new `state wipe-ostree` subcommand to the CLI that removes all `ostree` deployments from the system using native ostree bindings. This makes it easier to later rm -rf the stateroots and have a clean slate for the next test.
Solves containers#776 Right now the integration tests have some hacky code to clear out `ostree` stateroots (see `reset_root` function), it would be better if they could rely on a bootc command to take care of that for them instead This commit adds a new `state wipe-ostree` subcommand to the CLI that removes all `ostree` deployments from the system using native ostree bindings. This makes it easier to later rm -rf the stateroots and have a clean slate for the next test. Signed-off-by: Omer Tuchfeld <[email protected]>
Solves containers#776 Right now the integration tests have some hacky code to clear out `ostree` stateroots (see `reset_root` function), it would be better if they could rely on a bootc command to take care of that for them instead This commit adds a new `state wipe-ostree` subcommand to the CLI that removes all `ostree` deployments from the system using native ostree bindings. This makes it easier to later rm -rf the stateroots and have a clean slate for the next test. Signed-off-by: Omer Tuchfeld <[email protected]>
Right now the integration tests have some hacky code to clear out
ostree
stateroots (reset_root
), it would be better if they could rely on a bootc command to take care of that for them insteadOriginally posted by @cgwalters in #622 (comment)
The text was updated successfully, but these errors were encountered: