-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cli: Add new state wipe-ostree
subcommand
#777
Conversation
Tests failing because we need to check that /ostree even exists before attempting to mount |
Solves containers#776 Right now the integration tests have some hacky code to clear out `ostree` stateroots (see `reset_root` function), it would be better if they could rely on a bootc command to take care of that for them instead This commit adds a new `state wipe-ostree` subcommand to the CLI that removes all `ostree` deployments from the system using native ostree bindings. This makes it easier to later rm -rf the stateroots and have a clean slate for the next test. Signed-off-by: Omer Tuchfeld <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Is it normal for the tests to fail in this manner? |
@cgwalters WDYT? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice thanks!
The c10s tests are busted due to https://issues.redhat.com/browse/RHEL-56025 which should hopefully get sorted out soon
Not sure on this one, @henrywang ? |
Hi @cgwalters , could you please link me this log? Thanks. |
I can't find it but @vrothberg where did you see that? |
OH! I know this secure boot checking case. It's from
Secure boot is one of system checkings, such as bios/uefi, tpm device, partition size, and partition table. C9s and C10s are all disabled secure boot bootc/tests/e2e/bootc-install.sh Line 47 in 1ba8d1e
But fedora enabled secure boot. |
Solves containers#777 Signed-off-by: Omer Tuchfeld <[email protected]>
Solves #776
Right now the integration tests have some hacky code to clear out
ostree
stateroots (seereset_root
function), it would be better if they could rely on a bootc command to take care of that for them insteadThis commit adds a new
state wipe-ostree
subcommand to the CLI that removes allostree
deployments from the system using native ostree bindings. This makes it easier to later rm -rf the stateroots and have a clean slate for the next test.