Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hack/Containerfile: New file for local container builds #258

Merged
merged 1 commit into from
Jan 13, 2024

Conversation

cgwalters
Copy link
Collaborator

This is a relatively efficient container-oriented build flow suitable for local iteration.

.dockerignore Outdated Show resolved Hide resolved
This is a relatively efficient container-oriented build flow
suitable for local iteration.

Signed-off-by: Colin Walters <[email protected]>
@cgwalters
Copy link
Collaborator Author

OK exciting...CI just fell over with

error[E0308]: mismatched types
  --> /github/home/.cargo/registry/src/index.crates.io-6f17d22bba15001f/rustix-0.38.29/src/backend/linux_raw/net/netdevice.rs:23:78
   |
23 |     unsafe { ifreq.ifr_ifrn.ifrn_name[..if_name_bytes.len()].copy_from_slice(if_name_bytes) };
   |                                                              --------------- ^^^^^^^^^^^^^ expected `&[i8]`, found `&[u8]`
   |                                                              |
   |                                                              arguments to this method are incorrect
   |
   = note: expected reference `&[i8]`
              found reference `&[u8]`
note: method defined here
  --> /builddir/build/BUILD/rustc-1.75.0-src/library/core/src/slice/mod.rs:3661:12

error[E0604]: only `u8` can be cast as `char`, not `i8`
  --> /github/home/.cargo/registry/src/index.crates.io-6f17d22bba15001f/rustix-0.38.29/src/backend/linux_raw/net/netdevice.rs:47:22
   |
47 |             .map(|v| *v as char)
   |                      ^^^^^^^^^^ invalid cast
   |
help: try casting from `u8` instead
  --> /github/home/.cargo/registry/src/index.crates.io-6f17d22bba15001f/rustix-0.38.29/src/backend/linux_raw/net/netdevice.rs:47:22
   |
47 |             .map(|v| *v as char)
   |                      ^^^^^^^^^^

Some errors have detailed explanations: E0308, E0604.
For more information about an error, try `rustc --explain E0308`.
error: could not compile `rustix` (lib) due to 2 previous errors
Error: Process completed with exit code 101.

which seems clearly unrelated to this PR...hmmm....I wonder if this is another obscure incremental compilation bug.

@cgwalters
Copy link
Collaborator Author

Ah, this was bytecodealliance/rustix@f546573 but we aren't yet checking in Cargo.lock...perhaps it is time to do so.
/retest

@cgwalters cgwalters merged commit bbf8c6e into containers:main Jan 13, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants