install: Enable composefs by default, add a disable_composefs option
#304
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Let's enable this by default now, and allow disabling it if desired. Signed-off-by: Colin Walters <[email protected]>
ondrejbudai
reviewed
Feb 8, 2024
|
|
||
| - `filesystem`: See below. | ||
| - `disable_composefs`: A boolean, which will use the legacy ostree mode. |
There was a problem hiding this comment.
I think this needs more explanation, and maybe even a better name. Where exactly is being composefs disabled? In the kernel? In the filesystem layout in the root mount namespace? Might be also worth explaining what's the legacy ostree mode.
There was a problem hiding this comment.
Yeah...you're right this was under-documented (the real docs live on the ostree side right now). But the more I think about it the more I think this should be a property of the container, not bootc.
So ostreedev/ostree#3165 will make this work to configure that way.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Let's enable this by default now, and allow disabling it if desired.