-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Human-readable bootc status #602
Conversation
b36dc2d
to
fe49f2f
Compare
Thanks for working on this! I need to pull your PR and try it but just at a quick look, it's just a shorter YAML serialization right? I had been thinking we'd output something more like Before we try to write too much more code I think it'd be good to have a bike shed (maybe in the original issue) with some proposed example outputs that different people would like to see from this. Does that makes sense? |
fe49f2f
to
320e7ec
Compare
5cae1d0
to
efd9efd
Compare
efd9efd
to
2d43dac
Compare
@@ -116,6 +116,11 @@ pub(crate) struct StatusOpts { | |||
/// Only display status for the booted deployment. | |||
#[clap(long)] | |||
pub(crate) booted: bool, | |||
|
|||
/// Condense status into most important info, to reduce eye fatigue |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we can probably just go ahead and default to human-readable if we're writing to a tty by default.
That avoids the need to call it anything at all, and avoids "typing fatigue" from a potentially frequently used CLI option.
Arguably then, we could also simultaneously switch to JSON by default if we're not on a tty.
But, we probably do need a general option here like:
enum OutputFormat {
HumanReadable,
YAML,
JSON
}
or so and
pub(crate) format Option<OutputFormat>
or so.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
closing in favor of #738 |
store: If ostree >= 2024.3, retain content in `/var`
Fixes #408