Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tree-wide: rustfmt with group_imports = "StdExternalCrate" #642

Merged
merged 1 commit into from
Jun 26, 2024

Conversation

cgwalters
Copy link
Collaborator

We were inconsistent here; I prefer this StdExternalCrate style. Unfortunately it's not stabilized, but this is a manual run with current nightly rustfmt. On the positive side, rustfmt will preserve this ordering in the future.

We were inconsistent here; I prefer this `StdExternalCrate`
style. Unfortunately it's not stabilized, but this is a manual
run with current nightly rustfmt. On the positive side, rustfmt
will preserve this ordering in the future.

Signed-off-by: Colin Walters <[email protected]>
@github-actions github-actions bot added the area/install Issues related to `bootc install` label Jun 26, 2024
Copy link
Member

@vrothberg vrothberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cgwalters cgwalters enabled auto-merge June 26, 2024 13:43
@cgwalters cgwalters merged commit 54abf86 into containers:main Jun 26, 2024
14 of 19 checks passed
cgwalters pushed a commit to cgwalters/bootc that referenced this pull request Nov 5, 2024
Print previous version too when updating
cgwalters pushed a commit to cgwalters/bootc that referenced this pull request Nov 6, 2024
container: Add support for re-exporting a fetched container
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/install Issues related to `bootc install`
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants