kargs: A few more minor cleanups and test improvements #648
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Just reducing the size of the main `get_kargs`. Now that we've split out the helper, add a unit test. Signed-off-by: Colin Walters <[email protected]>
Instead of nested `if`, use `continue` to de-indent. Signed-off-by: Colin Walters <[email protected]>
Signed-off-by: Colin Walters <[email protected]>
Since we have two different read paths. Signed-off-by: Colin Walters <[email protected]>
| parse_kargs_toml(&s, sys_arch).with_context(|| format!("Parsing {name}"))?; | ||
| ret.extend(parsed_kargs); | ||
| } | ||
| let name = if let Some(name) = name.to_str() { |
There was a problem hiding this comment.
I'm totally fine with this change, but I guess I just personally don't like having else statements only containing continue even if it helps with code readability. Once again, okay with this change.
There was a problem hiding this comment.
It's somewhat idiomatic I think in Rust at least.
Although...actually for a while now there's been let-else which I think we can do a tree-wide conversion to.
cgwalters
pushed a commit
to cgwalters/bootc
that referenced
this pull request
Nov 5, 2024
….2.154 build(deps): bump libc from 0.2.153 to 0.2.154
cgwalters
added a commit
to cgwalters/bootc
that referenced
this pull request
Nov 6, 2024
tar: Handle hardlinks into /etc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.